Fixed self verification issue : TPLAPP-3984 97/153597/3
authorHyerim Kim <rimi.kim@samsung.com>
Fri, 29 Sep 2017 01:36:26 +0000 (10:36 +0900)
committerHyerim Kim <rimi.kim@samsung.com>
Thu, 12 Oct 2017 04:25:22 +0000 (13:25 +0900)
 - The subpanel icon is overlapped when the subpanel is changed to the move mode.
 - After moving subpanel item, it can't be moved focus using remote control direction key.

Change-Id: Iaa60181abea9b5a1b697318ec07e63a5a41f4acc
Signed-off-by: Hyerim Kim <rimi.kim@samsung.com>
TVHome/TVHome/Controls/SubPanelButton.xaml.cs
TVHome/TVHome/Views/MainPage.xaml.cs
TVHome/TVHome/Views/MainPanel.xaml.cs
TVHome/TVHome/Views/Panel.cs
TVHome/TVHome/Views/SubPanel.xaml.cs

index 9f671fe3839383acbbe191de3331ddc154e1be7f..7eca2fcf8533868c7937f2ef99f6e3541ffacef8 100755 (executable)
@@ -111,7 +111,7 @@ namespace TVHome.Controls
                 popup = null;
                 if (!IsButtonMoving)
                 {
-                    PanelButtonState = PanelButtonState.Focused;
+                    PanelButtonState = PanelButtonState.Show;
                 }
             };
 
index 9fbcfe66bffb4a03bc7780c55a023b885a9b68d4..a5cbdfd867c33380d43ce9c145744952e19feedf 100755 (executable)
@@ -114,7 +114,7 @@ namespace TVHome.Views
             AppsSubPanel.OnPanelShowing();
             SettingsSubPanel.OnPanelHiding();
 
-            PropertyChanged += MainPage_PropertyChanged;
+            PropertyChanged += MainPagePropertyChanged;
 
             App.SetHomeKeyListener((e, arg) =>
             {
@@ -160,10 +160,7 @@ namespace TVHome.Views
 
             AppsSubPanel.ItemSourceChanged += (s, e) =>
             {
-                if (CurrentState != AppState.HomeMove)
-                {
-                    InitializeAppsSubPanelButtonFocusChain();
-                }
+                InitializeAppsSubPanelButtonFocusChain();
             };
 
             InitializeMainPanelButtonFocusChain();
@@ -242,7 +239,7 @@ namespace TVHome.Views
         /// </summary>
         /// <param name="sender">The source of event</param>
         /// <param name="e">The event that is occurred when property is changed</param>
-        private void MainPage_PropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
+        private void MainPagePropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
         {
             if (e.PropertyName.CompareTo("CurrentState") == 0)
             {
index 918276b3f11f72128dfddc76bdf7a76a3aa21e63..dc73664251ef8cbbba3eed6e34c2ee30a9211c94 100755 (executable)
@@ -20,7 +20,6 @@ using LibTVRefCommonPortable.DataModels;
 using TVHome.ViewModels;
 using Xamarin.Forms;
 using LibTVRefCommonPortable.Utils;
-using System;
 
 namespace TVHome.Views
 {
@@ -213,19 +212,21 @@ namespace TVHome.Views
 
         public override void OnOptionMenuShowing()
         {
-            this.FadeTo(0, 300);
             IsVisible = false;
         }
 
-        public override void OnOptionMenuHiding()
+        public override void OnOptionMenuHiding(bool isMoveMode = false)
         {
-            this.FadeTo(1, 300);
+            if (isMoveMode)
+            {
+                return;
+            }
+
             IsVisible = true;
         }
 
         public override void OnMoveStarting()
         {
-            IsVisible = false;
         }
 
         public override void OnMoveFinishing()
index ea216e0b7ad39f5e3b8287f1fc4dd04541d06329..01242328d143f66b16486f0645beb77d9e832b3d 100755 (executable)
@@ -171,7 +171,7 @@ namespace TVHome.Views
 
         public abstract void OnOptionMenuShowing();
 
-        public abstract void OnOptionMenuHiding();
+        public abstract void OnOptionMenuHiding(bool isMoveMode = false);
 
         public abstract void OnMoveStarting();
 
@@ -207,7 +207,14 @@ namespace TVHome.Views
                 switch (previousPanelState)
                 {
                     case PanelState.ShowingOption:
-                        OnOptionMenuHiding();
+                        if (PanelState == PanelState.Moving)
+                        {
+                            OnOptionMenuHiding(true);
+                        }
+                        else
+                        {
+                            OnOptionMenuHiding();
+                        }
                         break;
                     case PanelState.Moving:
                         OnMoveFinishing();
index a0234c33927f6812db1f25aca953ae0c916952cf..6bb8babfc0e04d997b75b58ea005be0902ba0c03 100755 (executable)
@@ -390,10 +390,10 @@ namespace TVHome.Views
             var bounds = Bounds;
             bounds.Height += 300;
             bounds.Y -= 300;
-            this.LayoutTo(bounds, 0);
+            this.LayoutTo(bounds, 167);
         }
 
-        public override void OnOptionMenuHiding()
+        public override void OnOptionMenuHiding(bool isMoveMode = false)
         {
             DebuggingUtils.Dbg("OnHidingOptiongMenu - SubPanel");
             var bounds = Bounds;