staging: comedi: me4000: remove unnecessary Step 2b test in (*do_cmdtest)
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 23 Apr 2014 22:52:32 +0000 (15:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 21:07:50 +0000 (14:07 -0700)
This test is unnecessary. It covers all the possible combinations of the
scan_end_src and stop_src triggers so the final else can never be reached.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/me4000.c

index f43221f..5fc4850 100644 (file)
@@ -902,17 +902,6 @@ static int me4000_ai_do_cmd_test(struct comedi_device *dev,
                err |= -EINVAL;
        }
 
-       if (cmd->stop_src == TRIG_NONE && cmd->scan_end_src == TRIG_NONE) {
-       } else if (cmd->stop_src == TRIG_COUNT &&
-                  cmd->scan_end_src == TRIG_NONE) {
-       } else if (cmd->stop_src == TRIG_NONE &&
-                  cmd->scan_end_src == TRIG_COUNT) {
-       } else if (cmd->stop_src == TRIG_COUNT &&
-                  cmd->scan_end_src == TRIG_COUNT) {
-       } else {
-               err |= -EINVAL;
-       }
-
        if (err)
                return 2;