compositor: Correctly calculate changed sub image rectangle
authorRob Bradford <rob@linux.intel.com>
Mon, 2 Jul 2012 16:33:40 +0000 (17:33 +0100)
committerKristian Høgsberg <krh@bitplanet.net>
Mon, 2 Jul 2012 18:41:47 +0000 (14:41 -0400)
When calling glTexSubImage2D for sub image updates for SHM surfaces the
changed rectangle was being wrongly calculated. This resulted in interesting
redraw artefacts for clients using SHM.

src/compositor.c

index bdcc2cd..677b5c8 100644 (file)
@@ -1001,7 +1001,7 @@ update_shm_texture(struct weston_surface *surface)
                glPixelStorei(GL_UNPACK_SKIP_ROWS, rectangles[i].y1);
                glTexSubImage2D(GL_TEXTURE_2D, 0,
                                rectangles[i].x1, rectangles[i].y1,
-                               rectangles[i].x2 - rectangles[i].y1,
+                               rectangles[i].x2 - rectangles[i].x1,
                                rectangles[i].y2 - rectangles[i].y1,
                                GL_BGRA_EXT, GL_UNSIGNED_BYTE, data);
        }