ASoC: mediatek: mt8183: fix device_node leak
authorTzung-Bi Shih <tzungbi@google.com>
Fri, 24 Dec 2021 06:47:17 +0000 (14:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:05:04 +0000 (11:05 +0100)
[ Upstream commit cb006006fe6221f092fadaffd3f219288304c9ad ]

Fixes the device_node leak.

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20211224064719.2031210-3-tzungbi@google.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c

index a4d26a6..bda1032 100644 (file)
@@ -781,7 +781,11 @@ static int mt8183_da7219_max98357_dev_probe(struct platform_device *pdev)
                return ret;
        }
 
-       return devm_snd_soc_register_card(&pdev->dev, card);
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+
+       of_node_put(platform_node);
+       of_node_put(hdmi_codec);
+       return ret;
 }
 
 #ifdef CONFIG_OF
index 94dcbd3..c7b10c4 100644 (file)
@@ -780,7 +780,12 @@ mt8183_mt6358_ts3a227_max98357_dev_probe(struct platform_device *pdev)
                                 __func__, ret);
        }
 
-       return devm_snd_soc_register_card(&pdev->dev, card);
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+
+       of_node_put(platform_node);
+       of_node_put(ec_codec);
+       of_node_put(hdmi_codec);
+       return ret;
 }
 
 #ifdef CONFIG_OF