scsi: target: Remove redundant assignment to variable ret

The variable ret is being initialized with a value that is never read, the
assignment is redundant and can be removed.

Link: https://lore.kernel.org/r/20210721101519.42299-1-colin.king@canonical.com
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unused value")

diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
index b044999..072afd0 100644 (file)
--- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
+++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
@@ -234,7 +234,7 @@ cxgbit_get_r2t_ttt(struct iscsi_conn *conn, struct iscsi_cmd *cmd,
        struct cxgbit_device *cdev = csk->com.cdev;
        struct cxgbit_cmd *ccmd = iscsit_priv_cmd(cmd);
        struct cxgbi_task_tag_info *ttinfo = &ccmd->ttinfo;
-       int ret = -EINVAL;
+       int ret;
 
        if ((!ccmd->setup_ddp) ||
            (!test_bit(CSK_DDP_ENABLE, &csk->com.flags)))

diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 6d0b0e6..fdc3627 100644 (file)
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -241,7 +241,7 @@ static int tcm_loop_abort_task(struct scsi_cmnd *sc)
 {
        struct tcm_loop_hba *tl_hba;
        struct tcm_loop_tpg *tl_tpg;
-       int ret = FAILED;
+       int ret;
 
        /*
         * Locate the tcm_loop_hba_t pointer
@@ -261,7 +261,7 @@ static int tcm_loop_device_reset(struct scsi_cmnd *sc)
 {
        struct tcm_loop_hba *tl_hba;
        struct tcm_loop_tpg *tl_tpg;
-       int ret = FAILED;
+       int ret;
 
        /*
         * Locate the tcm_loop_hba_t pointer

diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index 44d9d02..4069a1e 100644 (file)
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -83,7 +83,7 @@ static int iblock_configure_device(struct se_device *dev)
        struct blk_integrity *bi;
        fmode_t mode;
        unsigned int max_write_zeroes_sectors;
-       int ret = -ENOMEM;
+       int ret;
 
        if (!(ib_dev->ibd_flags & IBDF_HAS_UDEV_PATH)) {
                pr_err("Missing udev_path= parameters for IBLOCK\n");