lib/test_kmod.c: remove a NULL test
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Apr 2020 03:10:35 +0000 (20:10 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 7 Apr 2020 17:43:43 +0000 (10:43 -0700)
The "info" pointer has already been dereferenced so checking here is too
late.  Fortunately, we never pass NULL pointers to the
test_kmod_put_module() function so the test can simply be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: http://lkml.kernel.org/r/20200228092452.vwkhthsn77nrxdy6@kili.mountain
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/test_kmod.c

index 9cf7762..e651c37 100644 (file)
@@ -204,7 +204,7 @@ static void test_kmod_put_module(struct kmod_test_device_info *info)
        case TEST_KMOD_DRIVER:
                break;
        case TEST_KMOD_FS_TYPE:
-               if (info && info->fs_sync && info->fs_sync->owner)
+               if (info->fs_sync && info->fs_sync->owner)
                        module_put(info->fs_sync->owner);
                break;
        default: