HID: intel-ish-hid: ipc: Disable and reenable ACPI GPE bit
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tue, 3 Oct 2023 15:53:32 +0000 (08:53 -0700)
committerJiri Kosina <jkosina@suse.cz>
Thu, 5 Oct 2023 10:50:35 +0000 (12:50 +0200)
The EHL (Elkhart Lake) based platforms provide a OOB (Out of band)
service, which allows to wakup device when the system is in S5 (Soft-Off
state). This OOB service can be enabled/disabled from BIOS settings. When
enabled, the ISH device gets PME wake capability. To enable PME wakeup,
driver also needs to enable ACPI GPE bit.

On resume, BIOS will clear the wakeup bit. So driver need to re-enable it
in resume function to keep the next wakeup capability. But this BIOS
clearing of wakeup bit doesn't decrement internal OS GPE reference count,
so this reenabling on every resume will cause reference count to overflow.

So first disable and reenable ACPI GPE bit using acpi_disable_gpe().

Fixes: 2e23a70edabe ("HID: intel-ish-hid: ipc: finish power flow for EHL OOB")
Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Closes: https://lore.kernel.org/lkml/CAAd53p4=oLYiH2YbVSmrPNj1zpMcfp=Wxbasb5vhMXOWCArLCg@mail.gmail.com/T/
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/intel-ish-hid/ipc/pci-ish.c

index 55cb25038e632bcfa962612fcd89b974a9bb8554..710fda5f19e1c9dc2d87f6b2e13a045de7a2bd41 100644 (file)
@@ -133,6 +133,14 @@ static int enable_gpe(struct device *dev)
        }
        wakeup = &adev->wakeup;
 
+       /*
+        * Call acpi_disable_gpe(), so that reference count
+        * gpe_event_info->runtime_count doesn't overflow.
+        * When gpe_event_info->runtime_count = 0, the call
+        * to acpi_disable_gpe() simply return.
+        */
+       acpi_disable_gpe(wakeup->gpe_device, wakeup->gpe_number);
+
        acpi_sts = acpi_enable_gpe(wakeup->gpe_device, wakeup->gpe_number);
        if (ACPI_FAILURE(acpi_sts)) {
                dev_err(dev, "enable ose_gpe failed\n");