Fix native tct failures related to cookie manager 11/300211/2
authorSatyaveer Singh <satyaveer.s@samsung.com>
Wed, 18 Oct 2023 12:19:37 +0000 (17:49 +0530)
committerDae-Hyun Ko <dhyuna.ko@samsung.com>
Thu, 19 Oct 2023 08:19:03 +0000 (08:19 +0000)
Due to changes on upstream code, now AllowFileSchemeCookies
should not be called on IO thread. This patch makes necessary changes.
With this, ewk cookie manager TCs are passing on NativeTCT.

Change-Id: I858b97098b829cd1a21db63cc96ca240adec3c36
Signed-off-by: Satyaveer Singh <satyaveer.s@samsung.com>
tizen_src/ewk/efl_integration/cookie_manager.cc
tizen_src/ewk/efl_integration/cookie_manager.h

index daf17242c85b29be3c6589b37ec87125788416ae..aef4bfd77f65ff77400488dc8a41ec67e351c268 100644 (file)
@@ -301,15 +301,6 @@ void CookieManager::AllowFileSchemeCookies(bool allow) {
                              ->GetDefaultStoragePartition()
                              ->GetCookieManagerForBrowserProcess();
 
-  content::GetIOThreadTaskRunner({})->PostTask(FROM_HERE,
-      base::BindOnce(&CookieManager::AllowFileSchemeCookiesOnIOThread,
-                     weak_ptr_factory_.GetWeakPtr(), cookie_manager, allow));
-}
-
-void CookieManager::AllowFileSchemeCookiesOnIOThread(
-    network::mojom::CookieManager* cookie_manager,
-    bool allow) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   cookie_manager->AllowFileSchemeCookies(
       allow, base::BindOnce(&CookieManager::OnAllowFileSchemeCookies,
                             weak_ptr_factory_.GetWeakPtr(), allow));
index acdfed239005e14ac430389e5954f8acfbee61dc..b45abacb7e3e846b237284c253a4c768187817cb 100644 (file)
@@ -127,9 +127,6 @@ class CookieManager : public base::RefCountedThreadSafe<CookieManager> {
   void FetchCookiesOnIOThread();
   void OnFetchComplete(const net::CookieList& cookies);
 
-  void AllowFileSchemeCookiesOnIOThread(
-      network::mojom::CookieManager* cookie_manager,
-      bool allow);
   void OnAllowFileSchemeCookies(bool allow, bool success);
 
   scoped_refptr<CookieManager> GetSharedThis();