parport: sunbpp: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 12 Jul 2018 21:29:55 +0000 (22:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2018 06:38:12 +0000 (08:38 +0200)
[ Upstream commit faa1a47388b33623e4d504c23569188907b039a0 ]

Return an error code on failure.  Change leading spaces to tab on the
first if.

Problem found using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/parport/parport_sunbpp.c

index 01cf1c1..8de3295 100644 (file)
@@ -286,12 +286,16 @@ static int bpp_probe(struct platform_device *op)
 
        ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations),
                      GFP_KERNEL);
-        if (!ops)
+       if (!ops) {
+               err = -ENOMEM;
                goto out_unmap;
+       }
 
        dprintk(("register_port\n"));
-       if (!(p = parport_register_port((unsigned long)base, irq, dma, ops)))
+       if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) {
+               err = -ENOMEM;
                goto out_free_ops;
+       }
 
        p->size = size;
        p->dev = &op->dev;