projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0020d4c
)
drm/rockchip: Drop unbalanced obj unref
author
Rob Clark
<robdclark@chromium.org>
Thu, 19 Jan 2023 23:17:34 +0000
(15:17 -0800)
committer
Heiko Stuebner
<heiko@sntech.de>
Sun, 5 Feb 2023 14:32:35 +0000
(15:32 +0100)
In the error path, rockchip_drm_gem_object_mmap() is dropping an obj
reference that it doesn't own.
Fixes: 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link:
https://patchwork.freedesktop.org/patch/msgid/20230119231734.2884543-1-robdclark@gmail.com
drivers/gpu/drm/rockchip/rockchip_drm_gem.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index c9507d27f0ba417dbbab987924f4512ae454542c..7f5698e3c554b27a3998a26d23b8b746a3347578 100644
(file)
--- a/
drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/
drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@
-262,9
+262,6
@@
static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj,
else
ret = rockchip_drm_gem_object_mmap_dma(obj, vma);
- if (ret)
- drm_gem_vm_close(vma);
-
return ret;
}