Fixed savce dereferenced issue. 81/213981/1 accepted/tizen/unified/20190918.010948 submit/tizen/20190917.121131
authorsungrae jo <seongrae.jo@samsung.com>
Tue, 17 Sep 2019 06:13:03 +0000 (15:13 +0900)
committersungrae jo <seongrae.jo@samsung.com>
Tue, 17 Sep 2019 06:13:03 +0000 (15:13 +0900)
Change-Id: I4da395f6999ea662fb2c823b449be17710e50fee
Signed-off-by: sungrae jo <seongrae.jo@samsung.com>
common/vc_cmd_db.c

index 7823832..74087db 100644 (file)
@@ -1605,13 +1605,13 @@ int vc_db_initialize(void)
        int ret = sqlite3_exec(g_db_handle, "pragma integrity_check", __vc_db_integrity_check_cb, NULL, NULL);
        if (true == is_db_corrupted || SQLITE_CORRUPT == ret) {
                SLOG(LOG_ERROR, vc_db_tag(), "[ERROR] Fail to open DB");
-               if (g_db_handle) {
-                       ret = db_util_close(g_db_handle);
-                       if (ret != SQLITE_OK) {
-                               SLOG(LOG_ERROR, vc_db_tag(), "[ERROR] Fail to close db, ret %d: %s", ret, sqlite3_errmsg(g_db_handle));
-                       }
-                       g_db_handle = NULL;
+
+               ret = db_util_close(g_db_handle);
+               if (ret != SQLITE_OK) {
+                       SLOG(LOG_ERROR, vc_db_tag(), "[ERROR] Fail to close db, ret %d: %s", ret, sqlite3_errmsg(g_db_handle));
                }
+               g_db_handle = NULL;
+
                if (0 != remove(g_path)) {
                        SLOG(LOG_ERROR, vc_db_tag(), "[Error] remove file(%s) is failed", g_path);
                        g_db_cnt = (g_db_cnt + 1) % 1000;