net: sched: don't set extack message in case the qdisc will be created
authorJiri Pirko <jiri@mellanox.com>
Thu, 28 Dec 2017 15:52:10 +0000 (16:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Dec 2017 17:18:31 +0000 (12:18 -0500)
If the qdisc is not found here, it is going to be created. Therefore,
this is not an error path. Remove the extack message set and don't
confuse user with error message in case the qdisc was created
successfully.

Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_api.c

index 3a3a1da..81ecf5b 100644 (file)
@@ -1402,10 +1402,8 @@ replay:
                                        return -EINVAL;
                                }
                                q = qdisc_lookup(dev, tcm->tcm_handle);
-                               if (!q) {
-                                       NL_SET_ERR_MSG(extack, "No qdisc found for specified handle");
+                               if (!q)
                                        goto create_n_graft;
-                               }
                                if (n->nlmsg_flags & NLM_F_EXCL) {
                                        NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override");
                                        return -EEXIST;