drivers/pinctrl/spear: don't check resource with devm_ioremap_resource
authorWolfram Sang <wsa@the-dreams.de>
Fri, 10 May 2013 08:17:04 +0000 (10:17 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 16 Jun 2013 09:56:49 +0000 (11:56 +0200)
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/spear/pinctrl-plgpio.c

index 3e5a887..6b090be 100644 (file)
@@ -528,18 +528,13 @@ static int plgpio_probe(struct platform_device *pdev)
        struct resource *res;
        int ret, irq, i;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "invalid IORESOURCE_MEM\n");
-               return -EBUSY;
-       }
-
        plgpio = devm_kzalloc(&pdev->dev, sizeof(*plgpio), GFP_KERNEL);
        if (!plgpio) {
                dev_err(&pdev->dev, "memory allocation fail\n");
                return -ENOMEM;
        }
 
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        plgpio->base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(plgpio->base))
                return PTR_ERR(plgpio->base);