perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 18 Nov 2022 06:31:36 +0000 (14:31 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 24 Nov 2022 10:09:25 +0000 (11:09 +0100)
pci_get_device() will increase the reference count for the returned
pci_dev, so snr_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count. Let's add the missing pci_dev_put().

Fixes: ee49532b38dd ("perf/x86/intel/uncore: Add IMC uncore support for Snow Ridge")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-4-wangxiongfeng2@huawei.com
arch/x86/events/intel/uncore_snbep.c

index 93b0f1f..44c2f87 100644 (file)
@@ -5111,6 +5111,8 @@ static int snr_uncore_mmio_map(struct intel_uncore_box *box,
 
        addr += box_ctl;
 
+       pci_dev_put(pdev);
+
        box->io_addr = ioremap(addr, type->mmio_map_size);
        if (!box->io_addr) {
                pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name);