cpufreq: s3c: fix unbalances of cpufreq policy refcount

The cpufreq_reboot_notifier_evt() call cpufreq_cpu_get() to get the
cpufreq policy of cpu0, meanwhile, it also increments the kobject
reference count to mark it busy. However, a corresponding call of
cpufreq_cpu_put() is ignored to decrement the kobject reference count
back, which may lead to a potential stuck risk that the cpuhp thread
deadly waits for dropping of kobject refcount when cpufreq policy free.

With this patch, the cpuhp thread can be easily exercised by attempting
to force an unbind of the CPUfreq driver.

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

diff --git a/drivers/cpufreq/s3c2416-cpufreq.c b/drivers/cpufreq/s3c2416-cpufreq.c
index 106910351c41683a23752ccde7b3da2069005ed3..5c221bc90210e8b1b702d37239a70748d88ddf21 100644 (file)
--- a/drivers/cpufreq/s3c2416-cpufreq.c
+++ b/drivers/cpufreq/s3c2416-cpufreq.c
@@ -304,6 +304,7 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this,
 {
        struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;
        int ret;
+       struct cpufreq_policy *policy;
 
        mutex_lock(&cpufreq_lock);
 
@@ -318,7 +319,16 @@ static int s3c2416_cpufreq_reboot_notifier_evt(struct notifier_block *this,
         */
        if (s3c_freq->is_dvs) {
                pr_debug("cpufreq: leave dvs on reboot\n");
-               ret = cpufreq_driver_target(cpufreq_cpu_get(0), FREQ_SLEEP, 0);
+
+               policy = cpufreq_cpu_get(0);
+               if (!policy) {
+                       pr_debug("cpufreq: get no policy for cpu0\n");
+                       return NOTIFY_BAD;
+               }
+
+               ret = cpufreq_driver_target(policy, FREQ_SLEEP, 0);
+               cpufreq_cpu_put(policy);
+
                if (ret < 0)
                        return NOTIFY_BAD;
        }

diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index 5d10030f2560218e0b1d381fca19817459165b2d..e84281e2561d22a5ff930cb8aca78bf805bef5c9 100644 (file)
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -555,8 +555,17 @@ static int s5pv210_cpufreq_reboot_notifier_event(struct notifier_block *this,
                                                 unsigned long event, void *ptr)
 {
        int ret;
+       struct cpufreq_policy *policy;
+
+       policy = cpufreq_cpu_get(0);
+       if (!policy) {
+               pr_debug("cpufreq: get no policy for cpu0\n");
+               return NOTIFY_BAD;
+       }
+
+       ret = cpufreq_driver_target(policy, SLEEP_FREQ, 0);
+       cpufreq_cpu_put(policy);
 
-       ret = cpufreq_driver_target(cpufreq_cpu_get(0), SLEEP_FREQ, 0);
        if (ret < 0)
                return NOTIFY_BAD;