staging: iio: adt7316: allow adt751x to use internal vref for all dacs
authorJeremy Fertic <jeremyfertic@gmail.com>
Wed, 12 Dec 2018 00:55:00 +0000 (17:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 May 2019 05:19:11 +0000 (07:19 +0200)
commit 10bfe7cc1739c22f0aa296b39e53f61e9e3f4d99 upstream.

With adt7516/7/9, internal vref is available for dacs a and b, dacs c and
d, or all dacs. The driver doesn't currently support internal vref for all
dacs. Change the else if to an if so both bits are checked rather than
just one or the other.

Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
Fixes: 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9 driver")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/addac/adt7316.c

index 3faffe59c9336768394533faffc66847e7b01071..a4ca21369879c1826961c80211867e11ad5017e7 100644 (file)
@@ -1089,7 +1089,7 @@ static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
                ldac_config = chip->ldac_config & (~ADT7516_DAC_IN_VREF_MASK);
                if (data & 0x1)
                        ldac_config |= ADT7516_DAC_AB_IN_VREF;
-               else if (data & 0x2)
+               if (data & 0x2)
                        ldac_config |= ADT7516_DAC_CD_IN_VREF;
        } else {
                ret = kstrtou8(buf, 16, &data);