drbd: Revert "Make sure we dont send state if a cluster wide state change is in progress"
authorPhilipp Reisner <philipp.reisner@linbit.com>
Sat, 5 Feb 2011 16:56:05 +0000 (17:56 +0100)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Wed, 28 Sep 2011 08:26:48 +0000 (10:26 +0200)
This reverts commit 6e9fdc92b77915d5c7ab8fea751f48378f8b0080.

1) This did not fixed the issue
2) Long sleeping work items can cause IO requests to take as long as
   the longest work item

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_main.c

index ae995ed..f33ca43 100644 (file)
@@ -951,10 +951,6 @@ int drbd_send_state(struct drbd_conf *mdev)
        struct p_state p;
        int ok = 0;
 
-       /* Grab state lock so we wont send state if we're in the middle
-        * of a cluster wide state change on another thread */
-       drbd_state_lock(mdev);
-
        mutex_lock(&mdev->tconn->data.mutex);
 
        p.state = cpu_to_be32(mdev->state.i); /* Within the send mutex */
@@ -966,7 +962,6 @@ int drbd_send_state(struct drbd_conf *mdev)
 
        mutex_unlock(&mdev->tconn->data.mutex);
 
-       drbd_state_unlock(mdev);
        return ok;
 }