iwlwifi: drv: load tlv debug data earlier
authorJohannes Berg <johannes.berg@intel.com>
Fri, 4 Feb 2022 10:25:06 +0000 (12:25 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 18 Feb 2022 08:40:53 +0000 (10:40 +0200)
There's no good reason to pick the opmode first and load this
under the mutex, so just load it before continuing. This will
let us load it asynchronously more easily later.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220204122220.a28df852f70d.Icaf6556d81bc137a459aabf0511d46c3861b0413@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-drv.c

index 5a9e644..ab52136 100644 (file)
@@ -1647,6 +1647,8 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
        /* We have our copies now, allow OS release its copies */
        release_firmware(ucode_raw);
 
+       iwl_dbg_tlv_load_bin(drv->trans->dev, drv->trans);
+
        mutex_lock(&iwlwifi_opmode_table_mtx);
        switch (fw->type) {
        case IWL_FW_DVM:
@@ -1663,8 +1665,6 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
        IWL_INFO(drv, "loaded firmware version %s op_mode %s\n",
                 drv->fw.fw_version, op->name);
 
-       iwl_dbg_tlv_load_bin(drv->trans->dev, drv->trans);
-
        /* add this device to the list of devices using this op_mode */
        list_add_tail(&drv->list, &op->drv);