staging: rtl8723bs: Remove function rtw_alloc_network()
authorNishka Dasgupta <nishka.dasgupta@yahoo.com>
Fri, 22 Mar 2019 14:38:26 +0000 (20:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Mar 2019 08:50:02 +0000 (09:50 +0100)
Remove function rtw_alloc_network() as all it does is call
_rtw_alloc_network().
Rename _rtw_alloc_network() to rtw_alloc_network().
Change references to _rtw_alloc_network() to refer to
rtw_alloc_network().
Issue first noticed while using Coccinelle and ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_cmd.c
drivers/staging/rtl8723bs/core/rtw_mlme.c
drivers/staging/rtl8723bs/include/rtw_mlme.h

index 04c6927..ecaa769 100644 (file)
@@ -2100,7 +2100,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
 
                rtw_indicate_connect(padapter);
        } else {
-               pwlan = _rtw_alloc_network(pmlmepriv);
+               pwlan = rtw_alloc_network(pmlmepriv);
                spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
                if (pwlan == NULL) {
                        pwlan = rtw_get_oldest_wlan_network(&pmlmepriv->scanned_queue);
index 8b3a095..552df9e 100644 (file)
@@ -143,7 +143,7 @@ struct      wlan_network *_rtw_dequeue_network(struct __queue *queue)
 }
 */
 
-struct wlan_network *_rtw_alloc_network(struct mlme_priv *pmlmepriv)/* _queue *free_queue) */
+struct wlan_network *rtw_alloc_network(struct  mlme_priv *pmlmepriv)
 {
        struct  wlan_network    *pnetwork;
        struct __queue *free_queue = &pmlmepriv->free_bss_pool;
@@ -161,7 +161,8 @@ struct      wlan_network *_rtw_alloc_network(struct mlme_priv *pmlmepriv)/* _queue *f
 
        list_del_init(&pnetwork->list);
 
-       RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("_rtw_alloc_network: ptr =%p\n", plist));
+       RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
+                ("rtw_alloc_network: ptr =%p\n", plist));
        pnetwork->network_type = 0;
        pnetwork->fixed = false;
        pnetwork->last_scanned = jiffies;
@@ -366,15 +367,6 @@ static struct      wlan_network *rtw_dequeue_network(struct __queue *queue)
 }
 */
 
-struct wlan_network *rtw_alloc_network(struct  mlme_priv *pmlmepriv);
-struct wlan_network *rtw_alloc_network(struct  mlme_priv *pmlmepriv)/* _queue  *free_queue) */
-{
-       struct  wlan_network    *pnetwork;
-
-       pnetwork = _rtw_alloc_network(pmlmepriv);
-       return pnetwork;
-}
-
 void rtw_free_network_nolock(struct adapter *padapter, struct wlan_network *pnetwork);
 void rtw_free_network_nolock(struct adapter *padapter, struct wlan_network *pnetwork)
 {
index 82f378c..2693b55 100644 (file)
@@ -598,7 +598,7 @@ extern void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv);
 
 /* extern struct wlan_network* _rtw_dequeue_network(struct __queue *queue); */
 
-extern struct wlan_network* _rtw_alloc_network(struct mlme_priv *pmlmepriv);
+extern struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv);
 
 
 extern void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwork, u8 isfreeall);