ALSA: hda - don't compare with yourself in fill_input_pin_labels
authorDavid Henningsson <david.henningsson@canonical.com>
Fri, 18 Jan 2013 14:43:02 +0000 (15:43 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 18 Jan 2013 14:49:04 +0000 (15:49 +0100)
Just stumbled over this one while reading the code.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c

index 10b14a9..e4e71fa 100644 (file)
@@ -2558,7 +2558,7 @@ static int fill_input_pin_labels(struct hda_codec *codec)
 
                label = hda_get_autocfg_input_label(codec, cfg, i);
                idx = 0;
-               for (j = i; j >= 0; j--) {
+               for (j = i - 1; j >= 0; j--) {
                        if (spec->input_labels[j] &&
                            !strcmp(spec->input_labels[j], label)) {
                                idx = spec->input_label_idxs[j] + 1;