iio: temperature: max31856: fix uninitialized error return
authorColin Ian King <colin.king@canonical.com>
Wed, 10 Apr 2019 18:23:51 +0000 (19:23 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 14 Apr 2019 12:50:09 +0000 (13:50 +0100)
Currently if mask is neither CHAN_INFO_RAW or CHAN_INFO_SCALE then
then an uninitialized error return 'ret' is returned. Fix this by
adding a default case that ensures -EINVAL is returned for this
specific case.

Addresses-Coverity: ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/temperature/max31856.c

index 6b67d6b..f184ba5 100644 (file)
@@ -210,6 +210,9 @@ static int max31856_read_raw(struct iio_dev *indio_dev,
                        return IIO_VAL_INT_PLUS_MICRO;
                }
                break;
+       default:
+               ret = -EINVAL;
+               break;
        }
 
        return ret;