xfs: remove the dummy iop_push implementation for inode creation items
authorChristoph Hellwig <hch@lst.de>
Sat, 29 Jun 2019 02:27:31 +0000 (19:27 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sat, 29 Jun 2019 02:27:31 +0000 (19:27 -0700)
This method should never be called, so don't waste code on it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_icreate_item.c

index 03c174f..cbaabc5 100644 (file)
@@ -83,23 +83,12 @@ xfs_icreate_item_committed(
        return (xfs_lsn_t)-1;
 }
 
-/* item can never get into the AIL */
-STATIC uint
-xfs_icreate_item_push(
-       struct xfs_log_item     *lip,
-       struct list_head        *buffer_list)
-{
-       ASSERT(0);
-       return XFS_ITEM_SUCCESS;
-}
-
 /*
  * This is the ops vector shared by all buf log items.
  */
 static const struct xfs_item_ops xfs_icreate_item_ops = {
        .iop_size       = xfs_icreate_item_size,
        .iop_format     = xfs_icreate_item_format,
-       .iop_push       = xfs_icreate_item_push,
        .iop_unlock     = xfs_icreate_item_unlock,
        .iop_committed  = xfs_icreate_item_committed,
 };