ide cd: do not set REQ_WRITE on requests.
authorMike Christie <mchristi@redhat.com>
Sun, 5 Jun 2016 19:32:19 +0000 (14:32 -0500)
committerJens Axboe <axboe@fb.com>
Tue, 7 Jun 2016 19:41:38 +0000 (13:41 -0600)
The block layer will set the correct READ/WRITE operation flags/fields
when creating a request, so there is not need for drivers to set the
REQ_WRITE flag.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/ide/ide-cd_ioctl.c

index 474173e..5887a7a 100644 (file)
@@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
           layer. the packet must be complete, as we do not
           touch it at all. */
 
-       if (cgc->data_direction == CGC_DATA_WRITE)
-               flags |= REQ_WRITE;
-
        if (cgc->sense)
                memset(cgc->sense, 0, sizeof(struct request_sense));