Remove redundant check from make_visible

This removes a check of the window type from make_visible.  This
function already checks that the window type is not CMD_WIN near the
top, so this condition can never be false.

gdb/ChangeLog
2019-06-25  Tom Tromey  <tom@tromey.com>

	* tui/tui-wingeneral.c (make_visible): Remove check of window
	type.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 174d12b..0d66374 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-06-25  Tom Tromey  <tom@tromey.com>
 
+       * tui/tui-wingeneral.c (make_visible): Remove check of window
+       type.
+
+2019-06-25  Tom Tromey  <tom@tromey.com>
+
        * tui/tui-win.c (tui_win_info::max_height)
        (tui_cmd_window::max_height): New methods.
        (new_height_ok): Call max_height.

diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 4d168af..73d77ce 100644 (file)
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -181,9 +181,7 @@ make_visible (struct tui_gen_win_info *win_info, bool visible)
     {
       if (!win_info->is_visible)
        {
-         tui_make_window (win_info,
-                          (win_info->type != CMD_WIN
-                           && !tui_win_is_auxillary (win_info->type)));
+         tui_make_window (win_info, !tui_win_is_auxillary (win_info->type));
          win_info->is_visible = true;
        }
     }