ASoC: Intel: avs: simplify S3 resume flows
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 17 Oct 2022 20:49:45 +0000 (15:49 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Oct 2022 18:16:32 +0000 (19:16 +0100)
The same code was directly copied from the skylake driver where it was
already questionable. Remove and simplify the flow.

Tested-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221017204946.207986-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/core.c

index 900d250..d067ce9 100644 (file)
@@ -580,7 +580,6 @@ static int __maybe_unused avs_suspend_common(struct avs_dev *adev)
 static int __maybe_unused avs_resume_common(struct avs_dev *adev, bool purge)
 {
        struct hdac_bus *bus = &adev->base.core;
-       struct hdac_ext_link *hlink;
        int ret;
 
        snd_hdac_display_power(bus, HDA_CODEC_IDX_CONTROLLER, true);
@@ -595,16 +594,6 @@ static int __maybe_unused avs_resume_common(struct avs_dev *adev, bool purge)
                return ret;
        }
 
-       /* turn off the links that were off before suspend */
-       list_for_each_entry(hlink, &bus->hlink_list, list) {
-               if (!hlink->ref_count)
-                       snd_hdac_ext_bus_link_power_down(hlink);
-       }
-
-       /* check dma status and clean up CORB/RIRB buffers */
-       if (!bus->cmd_dma_state)
-               snd_hdac_bus_stop_cmd_io(bus);
-
        return 0;
 }