rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 31 Mar 2021 09:13:43 +0000 (17:13 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 17 Apr 2021 17:30:01 +0000 (20:30 +0300)
Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that
stored value is overwritten before it can be used.

Coverity reports this problem as
CWE563: A value assigned to a variable is never used.
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:
rtl8188ee_bt_reg_init

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1617182023-110950-1-git-send-email-yang.lee@linux.alibaba.com
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c

index 861cc66..bf686a9 100644 (file)
@@ -2466,8 +2466,6 @@ void rtl8188ee_bt_reg_init(struct ieee80211_hw *hw)
 
        /* 0:Low, 1:High, 2:From Efuse. */
        rtlpriv->btcoexist.reg_bt_iso = 2;
-       /* 0:Idle, 1:None-SCO, 2:SCO, 3:From Counter. */
-       rtlpriv->btcoexist.reg_bt_sco = 3;
        /* 0:Disable BT control A-MPDU, 1:Enable BT control A-MPDU. */
        rtlpriv->btcoexist.reg_bt_sco = 0;
 }