cpupower: Fix comparing pointer to 0 coccicheck warns
authorShuah Khan <skhan@linuxfoundation.org>
Mon, 29 Jun 2020 20:02:22 +0000 (14:02 -0600)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 6 Jul 2020 22:10:40 +0000 (16:10 -0600)
Fix cocciccheck wanrns found by:
make coccicheck MODE=report M=tools/power/cpupower/

tools/power/cpupower/utils/helpers/bitmask.c:29:12-13: WARNING comparing pointer to 0, suggest !E
tools/power/cpupower/utils/helpers/bitmask.c:29:12-13: WARNING comparing pointer to 0
tools/power/cpupower/utils/helpers/bitmask.c:43:12-13: WARNING comparing pointer to 0

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/power/cpupower/utils/helpers/bitmask.c

index 6c7932f..649d87c 100644 (file)
@@ -26,11 +26,11 @@ struct bitmask *bitmask_alloc(unsigned int n)
        struct bitmask *bmp;
 
        bmp = malloc(sizeof(*bmp));
-       if (bmp == 0)
+       if (!bmp)
                return 0;
        bmp->size = n;
        bmp->maskp = calloc(longsperbits(n), sizeof(unsigned long));
-       if (bmp->maskp == 0) {
+       if (!bmp->maskp) {
                free(bmp);
                return 0;
        }
@@ -40,7 +40,7 @@ struct bitmask *bitmask_alloc(unsigned int n)
 /* Free `struct bitmask` */
 void bitmask_free(struct bitmask *bmp)
 {
-       if (bmp == 0)
+       if (!bmp)
                return;
        free(bmp->maskp);
        bmp->maskp = (unsigned long *)0xdeadcdef;  /* double free tripwire */