AMDGPU: Set scratch_en if there is dynamic stack but no fixed stack
authorMatt Arsenault <Matthew.Arsenault@amd.com>
Wed, 4 Jan 2023 20:17:54 +0000 (15:17 -0500)
committerMatt Arsenault <Matthew.Arsenault@amd.com>
Thu, 5 Jan 2023 01:51:18 +0000 (20:51 -0500)
llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
llvm/test/CodeGen/AMDGPU/enable-scratch-only-dynamic-stack.ll [new file with mode: 0644]

index 63b7645..d3e21f6 100644 (file)
@@ -908,7 +908,8 @@ void AMDGPUAsmPrinter::getSIProgramInfo(SIProgramInfo &ProgInfo,
   // anything to disable it if we know the stack isn't used here. We may still
   // have emitted code reading it to initialize scratch, but if that's unused
   // reading garbage should be OK.
-  const bool EnablePrivateSegment = ProgInfo.ScratchBlocks > 0;
+  const bool EnablePrivateSegment =
+      ProgInfo.ScratchBlocks > 0 || ProgInfo.DynamicCallStack;
   ProgInfo.ComputePGMRSrc2 =
       S_00B84C_SCRATCH_EN(EnablePrivateSegment) |
       S_00B84C_USER_SGPR(MFI->getNumUserSGPRs()) |
diff --git a/llvm/test/CodeGen/AMDGPU/enable-scratch-only-dynamic-stack.ll b/llvm/test/CodeGen/AMDGPU/enable-scratch-only-dynamic-stack.ll
new file mode 100644 (file)
index 0000000..e911eb0
--- /dev/null
@@ -0,0 +1,20 @@
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 --amdhsa-code-object-version=5 < %s | FileCheck -check-prefixes=GCN,COV5 %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 --amdhsa-code-object-version=4 < %s | FileCheck -check-prefixes=GCN,COV4 %s
+
+@gv.fptr0 = external hidden unnamed_addr addrspace(4) constant ptr, align 4
+
+; No stack objects, only indirect call has to enable scrathch
+; GCN-LABEL: test_indirect_call:
+
+; COV5: .amdhsa_private_segment_fixed_size 0{{$}}
+; COV4: .amdhsa_private_segment_fixed_size 16384{{$}}
+
+; GCN: .amdhsa_user_sgpr_private_segment_buffer 1
+
+; COV5: .amdhsa_uses_dynamic_stack 1
+; GCN: .amdhsa_system_sgpr_private_segment_wavefront_offset 1
+define amdgpu_kernel void @test_indirect_call() {
+  %fptr = load ptr, ptr addrspace(4) @gv.fptr0
+  call void %fptr()
+  ret void
+}