Fix Debian package build (dotnet/core-setup#2493)
authorrakeshsinghranchi <raksingh@microsoft.com>
Wed, 24 May 2017 01:57:42 +0000 (18:57 -0700)
committerGitHub <noreply@github.com>
Wed, 24 May 2017 01:57:42 +0000 (18:57 -0700)
* Fix Debian package build

- {shlibs:Depends} will pick up the correct packages for anything we link
  against so we don't need to include libssl and libcurl in the json config
  files.
- Add an explicit dependency on ICU (the runtime no longer links against it
  directly so dh_shlibdeps wasn't picking it up).

* Adding back libssl1.0.0 dependency.

Commit migrated from https://github.com/dotnet/core-setup/commit/c08a4ebfefab2d467639227588dbbb6f8aaf54db

src/installer/pkg/packaging/deb/dotnet-sharedframework-debian_config.json
src/installer/pkg/packaging/deb/package.targets

index 1bd8461..7423661 100644 (file)
@@ -31,7 +31,7 @@
     "debian_dependencies":{
         "%HOSTFXR_DEBIAN_PACKAGE_NAME%" : {},
         "libssl1.0.0" : {},
-        "libcurl3" : {}
+        "%LIBICU_PACKAGE_NAME%": {} 
     },
 
     "debian_ignored_dependencies" : [
index 20626a5..8ab4f76 100644 (file)
     <RemoveDir Condition="Exists('$(debIntermediatesDir)')" Directories="$(debIntermediatesDir)" />
     <MakeDir Directories="$(debIntermediatesDir)" />
 
+    <!-- Compute ICU Version --> 
+    <Exec Command="apt-cache search --names-only '^libicu[0-9]+$' | cut -d' ' -f1" 
+          ConsoleToMSBuild="true"> 
+       <Output TaskParameter="ConsoleOutput" PropertyName="LibIcuPackageName" /> 
+    </Exec> 
+
     <!-- Create empty debian layout -->
     <RemoveDir Condition="Exists('$(debLayoutDirectory)')" Directories="$(debLayoutDirectory)" />
     <MakeDir Directories="$(debLayoutDirectory)" />
       <SharedFrameworkTokenValue Include="%SHARED_FRAMEWORK_BRAND_NAME%">
         <ReplacementString>$(SharedFrameworkBrandName)</ReplacementString>
       </SharedFrameworkTokenValue>
+      <SharedFrameworkTokenValue Include="%LIBICU_PACKAGE_NAME%"> 
+        <ReplacementString>$(LibIcuPackageName)</ReplacementString> 
+      </SharedFrameworkTokenValue> 
+
     </ItemGroup>
 
     <ReplaceFileContents InputFile="$(ConfigJsonFile)"