video: Don't pass null vbuf to buffer_commit in hwc planes. 36/209036/3
authorSeunghun Lee <shiin.lee@samsung.com>
Tue, 21 May 2019 06:52:25 +0000 (15:52 +0900)
committerSooChan Lim <sc1.lim@samsung.com>
Wed, 3 Jul 2019 08:34:12 +0000 (08:34 +0000)
Change-Id: Ic23b720a4cea13722c977a3ae4c6451fccae241f

src/bin/video/iface/e_video_hwc_planes.c

index 209e6fa413f2c051eaf51da93cf4c8c4cde8e779..a002bcbd79693ca688eb5ff2d2632fa367df0ad9 100644 (file)
@@ -464,16 +464,6 @@ _e_video_hwc_planes_buffer_commit(E_Video_Hwc_Planes *evhp, E_Comp_Wl_Video_Buf
    E_Client_Video_Info info, old_info;
    tdm_error ret;
 
-   if (!vbuf)
-     {
-        if (evhp->tdm.layer)
-          {
-             VIN("unset layer: hide", evhp->base.ec);
-             _e_video_hwc_planes_tdm_layer_unset(evhp);
-          }
-        return EINA_TRUE;
-     }
-
    if (!evhp->tdm.layer)
      {
         VIN("set layer: show", evhp->base.ec);
@@ -551,7 +541,11 @@ _e_video_hwc_planes_cb_evas_hide(void *data, Evas *e EINA_UNUSED, Evas_Object *o
      return;
 
    VIN("evas hide", evhp->base.ec);
-   _e_video_hwc_planes_buffer_commit(evhp, NULL);
+   if (evhp->tdm.layer)
+     {
+        VIN("unset layer: hide", evhp->base.ec);
+        _e_video_hwc_planes_tdm_layer_unset(evhp);
+     }
 }
 
 static tdm_error
@@ -832,9 +826,21 @@ static Eina_Bool
 _e_video_hwc_planes_iface_buffer_commit(E_Video_Hwc *evh, E_Comp_Wl_Video_Buf *vbuf)
 {
    E_Video_Hwc_Planes *evhp;
+   Eina_Bool ret = EINA_TRUE;
 
    evhp = (E_Video_Hwc_Planes *)evh;
-   return _e_video_hwc_planes_buffer_commit(evhp, vbuf);
+   if (!vbuf)
+     {
+        if (evhp->tdm.layer)
+          {
+             VIN("unset layer: hide", evhp->base.ec);
+             _e_video_hwc_planes_tdm_layer_unset(evhp);
+          }
+     }
+   else
+     ret = _e_video_hwc_planes_buffer_commit(evhp, vbuf);
+
+   return ret;
 }
 
 static Eina_Bool