watchdog: rtd119x_wdt: Fix remove function
authorGuenter Roeck <linux@roeck-us.net>
Sun, 7 Apr 2019 15:29:35 +0000 (08:29 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:13 +0000 (21:02 +0200)
The driver registers the watchdog with devm_watchdog_register_device() but
still calls watchdog_unregister_device() on remove. Since clocks have to
be stopped when removing the driver, after the watchdog device has been
unregistered, we can not drop the call to watchdog_unregister_device().
Use watchdog_register_device() to register the watchdog.

Fixes: 2bdf6acbfead7 ("watchdog: Add Realtek RTD1295")
Cc: Andreas Färber <afaerber@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/rtd119x_wdt.c

index d823c9d..cb17c49 100644 (file)
@@ -133,7 +133,7 @@ static int rtd119x_wdt_probe(struct platform_device *pdev)
        rtd119x_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout);
        rtd119x_wdt_stop(&data->wdt_dev);
 
-       ret = devm_watchdog_register_device(&pdev->dev, &data->wdt_dev);
+       ret = watchdog_register_device(&data->wdt_dev);
        if (ret) {
                clk_disable_unprepare(data->clk);
                clk_put(data->clk);