Add support for homescreen, and keyboard menu. 20/161820/3
authorPawel Kurowski <p.kurowski2@samsung.com>
Mon, 27 Nov 2017 15:21:08 +0000 (16:21 +0100)
committerPawel Kurowski <p.kurowski2@samsung.com>
Fri, 1 Dec 2017 17:28:29 +0000 (18:28 +0100)
Change-Id: I268b906b82b56267e63f53a3b08805ddb36b3bdf

src/MenuBuilder.cpp
src/SelectActivity.cpp
tests/ui-scenarios/MenuBuilderTests.cpp

index 6f87f6a..1d5c018 100644 (file)
@@ -643,7 +643,7 @@ MenuBuilderImplementation::MenuBuilderImplementation()
                        recentApps, homeScreen, back, buttonsAndKeys
                }
        }));
-       addToMap("IDS_MENU_MAIN_HOME_APPS", std::make_shared<MenuImplementation>(MenuImplementation {
+       addToMap("IDS_MENU_MAIN_HOME_SCREEN", std::make_shared<MenuImplementation>(MenuImplementation {
                {
                        tap, leftPage, rightPage, emptyItem,
                        gestures, actions, settings, recentApps,
index cd3f329..6e29baa 100644 (file)
@@ -407,7 +407,6 @@ std::string SelectActivity::getCompleteLabelOfMenu()
 
 std::string SelectActivity::getCompleteLabelOfMainMenu()
 {
-       //TODO sip, home-apps
        auto phoneCallState = getPhoneCallState();
 
        if (phoneCallState && *phoneCallState == TELEPHONY_CALL_STATE_CONNECTED)
@@ -415,6 +414,12 @@ std::string SelectActivity::getCompleteLabelOfMainMenu()
        if (phoneCallState && *phoneCallState == TELEPHONY_CALL_STATE_CONNECTING)
                return "IDS_MENU_MAIN_INCOMING_CALL";
 
+       if (realUiElement->getApplicationCategory() == UIElement::ApplicationCategory::HOMESCREEN)
+               return "IDS_MENU_MAIN_HOME_SCREEN";
+
+       if (realUiElement->getApplicationCategory() == UIElement::ApplicationCategory::KEYBOARD)
+               return "IDS_MENU_MAIN_SIP";
+
        if (isRealUIElementSlider())
                return "IDS_MENU_MAIN_SLIDER";
 
index 224ad88..f184626 100644 (file)
@@ -174,7 +174,7 @@ TEST_F(MenuBuilderTest, testImpactOfContextualMenuVconfValueOnMenuMain)
        eventLoop::run([]() {
                Singleton<VConfInterface>::instance().set(VCONF_KEY_SHOW_CONTEXTUAL_MENU, false);
        });
-       testIfMenuMainIsEqualToNormal("IDS_MENU_MAIN_HOME_APPS");
+       testIfMenuMainIsEqualToNormal("IDS_MENU_MAIN_HOME_SCREEN");
        testIfMenuMainIsEqualToNormal("IDS_MENU_MAIN_SLIDER");
        testIfMenuMainIsEqualToNormal("IDS_MENU_MAIN_EDITABLE_TEXT");
        testIfMenuMainIsEqualToNormal("IDS_MENU_MAIN_SIP");
@@ -198,7 +198,7 @@ TEST_F(MenuBuilderTest, testHidingMenuItems)
 TEST_F(MenuBuilderTest, testContentOfMenuMainHomeApps)
 {
        setMenuKeys(true);
-       testMenuContent("IDS_MENU_MAIN_HOME_APPS", {
+       testMenuContent("IDS_MENU_MAIN_HOME_SCREEN", {
                "IDS_TAP", "IDS_LEFT_PAGE", "IDS_RIGHT_PAGE", "", "IDS_GESTURES", "IDS_ACTIONS", "IDS_SETTINGS",
                "IDS_RECENT_APPS", "IDS_HOME_SCREEN", "IDS_BACK", "IDS_BUTTONS_AND_KEYS"
        });