e_desk_area/e_info_server: fix coverity issue 13/305913/2
authorDoyoun Kang <doyoun.kang@samsung.com>
Tue, 13 Feb 2024 09:11:32 +0000 (18:11 +0900)
committerDoyoun Kang <doyoun.kang@samsung.com>
Tue, 13 Feb 2024 09:39:11 +0000 (09:39 +0000)
Change-Id: I24623d39474f8cb81f7754a7f0365047d33dc270

src/bin/e_desk_area.c
src/bin/e_info_server.c

index e97b5a0..0f5d249 100644 (file)
@@ -2554,6 +2554,9 @@ _find_top_ec_in_below_edgc_layer(E_Desk_Area *eda, E_Client *ec)
    edgc_layer = e_client_desk_area_client_layer_get(ec);
    if (!_check_desk_area_client_layer_validation(edgc_layer)) return NULL;
 
+   // if edgc_layer is E_DESK_AREA_CLIENT_LAYER_DESKTOP, then there is no below layer.
+   if (edgc_layer == E_DESK_AREA_CLIENT_LAYER_DESKTOP) return NULL;
+
    for (i = edgc_layer-1; i >= E_DESK_AREA_CLIENT_LAYER_DESKTOP; i--)
      {
         EINA_LIST_FOREACH(eda->ec_lists[i], l, top)
index 43fe9ec..2455d0a 100644 (file)
@@ -4320,8 +4320,8 @@ _e_info_server_cb_buffer_change(void *data, int type, void *event)
              w = tbm_surface_get_width(capturable_tbm_surface);
              h = tbm_surface_get_height(capturable_tbm_surface);
 
-             EINA_SAFETY_ON_FALSE_RETURN_VAL((w != 0), ECORE_CALLBACK_PASS_ON);
-             EINA_SAFETY_ON_FALSE_RETURN_VAL((h != 0), ECORE_CALLBACK_PASS_ON);
+             EINA_SAFETY_ON_FALSE_RETURN_VAL((w > 0), ECORE_CALLBACK_PASS_ON);
+             EINA_SAFETY_ON_FALSE_RETURN_VAL((h > 0), ECORE_CALLBACK_PASS_ON);
 
              row = (((box / w) * box_size) % h);
              col = box % w;