bluetooth: ldac: Fix missing check for RTP LDAC payloader element
authorSanchayan Maity <sanchayan@asymptotic.io>
Wed, 19 May 2021 08:07:37 +0000 (13:37 +0530)
committerSanchayan Maity <sanchayan@asymptotic.io>
Wed, 19 May 2021 12:39:43 +0000 (18:09 +0530)
While at it, improve the error message to include the name of the
element which was not found.

Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/560>

src/modules/bluetooth/a2dp-codec-ldac-gst.c

index 036d3b4..749cfbe 100644 (file)
@@ -41,10 +41,16 @@ static bool can_be_supported(bool for_encoding) {
 
     element_factory = gst_element_factory_find("ldacenc");
     if (element_factory == NULL) {
-        pa_log_info("LDAC encoder not found");
+        pa_log_info("LDAC encoder element `ldacenc` not found");
         return false;
     }
+    gst_object_unref(element_factory);
 
+    element_factory = gst_element_factory_find("rtpldacpay");
+    if (element_factory == NULL) {
+        pa_log_info("LDAC RTP payloader element `rtpldacpay` not found");
+        return false;
+    }
     gst_object_unref(element_factory);
 
     return true;