evdev: fix handling of click wheel on parsing errors
authorPeter Hutterer <peter.hutterer@who-t.net>
Wed, 31 Aug 2016 23:55:32 +0000 (09:55 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Wed, 31 Aug 2016 23:57:26 +0000 (09:57 +1000)
Introduced in b02acd346b, we need to check the angle returned by the parsing
function, not the variable passed in.

Found by Coverity

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
src/evdev.c

index 4ec74a5..bc85856 100644 (file)
@@ -1831,7 +1831,7 @@ evdev_read_wheel_click_prop(struct evdev_device *device,
                return false;
 
        val = parse_mouse_wheel_click_angle_property(prop);
-       if (angle) {
+       if (val) {
                *angle = val;
                return true;
        }