bits: Print an error if someone tries to create an image with bpp < depth

Something in the X server apparently does this.

diff --git a/pixman/pixman-bits-image.c b/pixman/pixman-bits-image.c
index a3bcd69..23a3796 100644 (file)
--- a/pixman/pixman-bits-image.c
+++ b/pixman/pixman-bits-image.c
@@ -1044,6 +1044,12 @@ pixman_image_create_bits (pixman_format_code_t format,
     return_val_if_fail (bits == NULL ||
                         (rowstride_bytes % sizeof (uint32_t)) == 0, NULL);
 
+    if (PIXMAN_FORMAT_BPP (format) < PIXMAN_FORMAT_DEPTH (format))
+    {
+       fprintf (stderr, "Bad format passed to pixman_image_create_bits();\n");
+       return NULL;
+    }
+
     if (!bits && width && height)
     {
        free_me = bits = create_bits (format, width, height, &rowstride_bytes);