Fix segfault in fsrcnn.tflite in GpuAcc
authorTeresa Charlin <teresa.charlinreyes@arm.com>
Wed, 3 Feb 2021 17:01:23 +0000 (17:01 +0000)
committerTeresaARM <teresa.charlinreyes@arm.com>
Wed, 3 Feb 2021 21:49:33 +0000 (21:49 +0000)
* In CLDirectConvolution check for non-bias separately

Resolves: COMPMID-4214
Change-Id: I83c0688e9b48d059665bbc6e1f0f050a516132d6
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4980
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp

index 3b6c306734f017f18b938d4c287e86ca5d70ef57..3ca72b3e5d8da01e711159e12c76b5d5c256bf7f 100644 (file)
@@ -381,8 +381,11 @@ void CLDirectConvolutionLayerKernel::configure(const CLCompileContext &compile_c
         const unsigned int pad_left         = conv_info.pad_left();
         const unsigned int pad_top          = conv_info.pad_top();
 
-        build_options.add_option_if(_biases != nullptr, std::string("-DHAS_BIAS"));
-        build_options.add_option_if(_biases != nullptr, std::string("-DBIA_DATA_TYPE=" + get_cl_type_from_data_type(_biases->info()->data_type())));
+        if (_biases != nullptr)
+        {
+            build_options.add_option(std::string("-DHAS_BIAS"));
+            build_options.add_option(std::string("-DBIA_DATA_TYPE=" + get_cl_type_from_data_type(_biases->info()->data_type())));
+        }
         build_options.add_option("-DSRC_WIDTH=" + support::cpp11::to_string(_input->info()->dimension(width_idx)));
         build_options.add_option("-DSRC_HEIGHT=" + support::cpp11::to_string(_input->info()->dimension(height_idx)));
         build_options.add_option("-DSRC_CHANNELS=" + support::cpp11::to_string(_input->info()->dimension(channel_idx)));