backout SDVO control bus check and comment why this is a bad idea
authorDave Airlie <airlied@linux.ie>
Wed, 18 Apr 2007 23:43:46 +0000 (09:43 +1000)
committerDave Airlie <airlied@linux.ie>
Wed, 18 Apr 2007 23:43:46 +0000 (09:43 +1000)
linux-core/intel_sdvo.c

index f004c76..507b0f5 100644 (file)
@@ -297,14 +297,14 @@ int intel_sdvo_get_pixel_multiplier(struct drm_display_mode *mode)
                return 4;
 }
 
-static bool intel_sdvo_set_control_bus_switch(struct drm_output *output, u8 target)
+/**
+ * Don't check status code from this as it switches the bus back to the
+ * SDVO chips which defeats the purpose of doing a bus switch in the first
+ * place.
+ */
+void intel_sdvo_set_control_bus_switch(struct drm_output *output, u8 target)
 {
-       u8 status;
-
        intel_sdvo_write_cmd(output, SDVO_CMD_SET_CONTROL_BUS_SWITCH, &target, 1);
-       status = intel_sdvo_read_response(output, NULL, 0);
-
-       return (status == SDVO_CMD_STATUS_SUCCESS);
 }
 
 static bool intel_sdvo_set_target_input(struct drm_output *output, bool target_0, bool target_1)