Adding comments based on review https://codereview.appspot.com/7300072/

git-svn-id: http://skia.googlecode.com/svn/trunk@7686 2bbb7eff-a529-9590-31e7-b0007b416f81

diff --git a/include/core/SkTileGridPicture.h b/include/core/SkTileGridPicture.h
index 77189bb..28d545a 100644 (file)
--- a/include/core/SkTileGridPicture.h
+++ b/include/core/SkTileGridPicture.h
@@ -29,7 +29,9 @@ public:
      * @param borderPixels pixels of overlap between adjacent tiles. Set this
      *  value to match the border overlap that is applied to tiles by user
      *  code. Properly setting this value will help improve performance
-     *  when performing tile-aligned playbacks.
+     *  when performing tile-aligned playbacks with query regions that
+     *  match tile bounds outset by borderPixels pixels. Such outsets
+     *  are often used to prevent filtering artifacts at tile boundaries.
      */
     SkTileGridPicture(int tileWidth, int tileHeight, int width, int height, int borderPixels = 0);
     virtual SkBBoxHierarchy* createBBoxHierarchy() const SK_OVERRIDE;

diff --git a/src/core/SkTileGrid.cpp b/src/core/SkTileGrid.cpp
index 51c40cc..25a1fa8 100644 (file)
--- a/src/core/SkTileGrid.cpp
+++ b/src/core/SkTileGrid.cpp
@@ -56,6 +56,9 @@ void SkTileGrid::insert(void* data, const SkIRect& bounds, bool) {
 }
 
 void SkTileGrid::search(const SkIRect& query, SkTDArray<void*>* results) {
+    // Convert the query rectangle from device coordinates to tile coordinates
+    // by rounding outwards to the nearest tile boundary so that the resulting tile
+    // region includes the query rectangle. (using truncating division to "floor")
     int tileStartX = (query.left() + fBorderPixels) / fTileWidth;
     int tileEndX = (query.right() + fTileWidth - fBorderPixels) / fTileWidth;
     int tileStartY = (query.top() + fBorderPixels) / fTileHeight;