Fixed ASAN issue.

3.  memcpy(arp_data->arp_source_mac, source_mac_address, MAX_SIZE_BUFFER-1);
source mac address is 18 bytes but 127 bytes are being read

Change-Id: I09b0ad4ffd27ea3a9dc0e1b7cd44eac31a083066
Signed-off-by: saerome.kim <saerome.kim@samsung.com>

diff --git a/packaging/ua-plugin-wifi-dummy.spec b/packaging/ua-plugin-wifi-dummy.spec
index 796c825..87b8207 100644 (file)
--- a/packaging/ua-plugin-wifi-dummy.spec
+++ b/packaging/ua-plugin-wifi-dummy.spec
@@ -3,7 +3,7 @@
 
 Name:       ua-plugin-wifi-dummy
 Summary:    Wi-Fi User awareness plugin for VD
-Version:    0.9.0
+Version:    0.10.0
 Release:    1
 License:    Apache-2.0
 Source0:    %{name}-%{version}.tar.gz

diff --git a/src/wifi-scan.c b/src/wifi-scan.c
index f4583b0..44b1421 100644 (file)
--- a/src/wifi-scan.c
+++ b/src/wifi-scan.c
@@ -43,8 +43,7 @@ static int __arp_packet_make(const char *mac)
                return UAS_STATUS_FAIL;
        }
 
-       memcpy(arp_data->arp_source_mac, source_mac_address, MAX_SIZE_BUFFER-1);
-       arp_data->arp_source_mac[MAX_SIZE_BUFFER-1]=0x00;
+       g_strlcpy(arp_data->arp_source_mac, source_mac_address, MAX_SIZE_BUFFER);
        source_mac = ether_aton(source_mac_address);
 
        if (source_mac == NULL) {
@@ -58,7 +57,7 @@ static int __arp_packet_make(const char *mac)
 
        memset(&arp_data->arp, 0, sizeof(arp_data->arp));
        memcpy(arp_data->arp.h_source, source_mac, MAC_ADD_LENGTH);
-    memcpy(arp_data->arp.s_hwaddr, source_mac, MAC_ADD_LENGTH);
+       memcpy(arp_data->arp.s_hwaddr, source_mac, MAC_ADD_LENGTH);
 
        dest_mac = ether_aton(mac);