fixup! [HOTFIX] Web app is crashing during exit 28/307428/3
authoruzair <uzair.jaleel@samsung.com>
Fri, 8 Mar 2024 07:34:46 +0000 (13:04 +0530)
committerDae-Hyun Ko <dhyuna.ko@samsung.com>
Fri, 8 Mar 2024 08:56:59 +0000 (08:56 +0000)
Below change converts CHECK to DCHECK at required places
to fix random crashes in web apps on TV.

Change-Id: I2020d2b86eade133c4382fc85b0b65ca726d4450
Signed-off-by: uzair <uzair.jaleel@samsung.com>
mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

index 9bf3e76..f0d00ca 100644 (file)
@@ -509,7 +509,7 @@ scoped_refptr<ThreadSafeProxy> InterfaceEndpointClient::CreateThreadSafeProxy(
 }
 
 ScopedInterfaceEndpointHandle InterfaceEndpointClient::PassHandle() {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
   DCHECK(!has_pending_responders());
 
   if (!handle_.is_valid())
@@ -531,7 +531,7 @@ void InterfaceEndpointClient::SetFilter(std::unique_ptr<MessageFilter> filter) {
 }
 
 void InterfaceEndpointClient::RaiseError() {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
 
   if (!handle_.pending_association())
     handle_.group_controller()->RaiseError();
@@ -539,7 +539,7 @@ void InterfaceEndpointClient::RaiseError() {
 
 void InterfaceEndpointClient::CloseWithReason(uint32_t custom_reason,
                                               base::StringPiece description) {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
 
   auto handle = PassHandle();
   handle.ResetWithReason(custom_reason, description);
@@ -575,7 +575,7 @@ bool InterfaceEndpointClient::AcceptWithResponder(
 
 bool InterfaceEndpointClient::SendMessage(Message* message,
                                           bool is_control_message) {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
   DCHECK(!message->has_flag(Message::kFlagExpectsResponse));
   DCHECK(!handle_.pending_association());
 
@@ -611,7 +611,7 @@ bool InterfaceEndpointClient::SendMessageWithResponder(
     bool is_control_message,
     SyncSendMode sync_send_mode,
     std::unique_ptr<MessageReceiver> responder) {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
   DCHECK(message->has_flag(Message::kFlagExpectsResponse));
   DCHECK(!handle_.pending_association());
 
@@ -692,7 +692,7 @@ bool InterfaceEndpointClient::SendMessageWithResponder(
 }
 
 bool InterfaceEndpointClient::HandleIncomingMessage(Message* message) {
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
 
   // Accept() may invalidate `this` and `message` so we need to copy the
   // members we need for logging in case of an error.
@@ -715,7 +715,7 @@ void InterfaceEndpointClient::NotifyError(
                 info->set_mojo_interface_tag(interface_name_);
               });
 
-  CHECK(sequence_checker_.CalledOnValidSequence());
+  DCHECK(sequence_checker_.CalledOnValidSequence());
 
   if (encountered_error_)
     return;