watchdog: imx2_wdt: Improve dev_crit() message
authorFabio Estevam <festevam@denx.de>
Tue, 22 Aug 2023 13:52:55 +0000 (10:52 -0300)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Fri, 25 Aug 2023 14:19:13 +0000 (16:19 +0200)
After issuing a "poweroff" command the board goes through the
expected power-off sequence and turns it off completely:

systemd-shutdown[1]: Powering off.
imx2-wdt 30280000.watchdog: Device shutdown: Expect reboot!
reboot: Power down

The "Expect reboot!" message is misleading because in the
power-off case, no reboot is expected to happen at all.

Avoid the confusion by removing the "Expect reboot!" message.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230822135255.1013981-1-festevam@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/imx2_wdt.c

index 1a27665..42e8ffa 100644 (file)
@@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev)
                 */
                imx2_wdt_set_timeout(wdog, IMX2_WDT_MAX_TIME);
                imx2_wdt_ping(wdog);
-               dev_crit(&pdev->dev, "Device shutdown: Expect reboot!\n");
+               dev_crit(&pdev->dev, "Device shutdown.\n");
        }
 }