staging: r8188eu: go2asoc is not needed
authorMartin Kaiser <martin@kaiser.cx>
Mon, 24 Oct 2022 08:14:17 +0000 (10:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Oct 2022 17:19:39 +0000 (19:19 +0200)
Remove the go2asoc variable in OnAuthClient and call start_clnt_assoc
directly. This makes the code a tiny bit shorter.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221024081417.66441-18-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index ba95d23..254832a 100644 (file)
@@ -796,7 +796,6 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram
 {
        unsigned int    seq, len, status, offset;
        unsigned char   *p;
-       unsigned int    go2asoc = 0;
        struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
        struct mlme_ext_info    *pmlmeinfo = &pmlmeext->mlmext_info;
        u8 *pframe = precv_frame->rx_data;
@@ -843,15 +842,12 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram
                        return;
                } else {
                        /*  open system */
-                       go2asoc = 1;
+                       start_clnt_assoc(padapter);
                }
        } else if (seq == 4) {
                if (pmlmeinfo->auth_algo == dot11AuthAlgrthm_Shared)
-                       go2asoc = 1;
+                       start_clnt_assoc(padapter);
        }
-
-       if (go2asoc)
-               start_clnt_assoc(padapter);
 }
 
 static void UpdateBrateTbl(u8 *mbrate)