projects
/
platform
/
kernel
/
linux-amlogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3c4fef9
)
RMDA/cm: Fix missing ib_cm_destroy_id() in ib_cm_insert_listen()
author
Jason Gunthorpe
<jgg@mellanox.com>
Fri, 21 Feb 2020 15:20:26 +0000
(15:20 +0000)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 11 Mar 2020 06:53:13 +0000
(07:53 +0100)
commit
c14dfddbd869bf0c2bafb7ef260c41d9cebbcfec
upstream.
The algorithm pre-allocates a cm_id since allocation cannot be done while
holding the cm.lock spinlock, however it doesn't free it on one error
path, leading to a memory leak.
Fixes:
067b171b8679
("IB/cm: Share listening CM IDs")
Link:
https://lore.kernel.org/r/20200221152023.GA8680@ziepe.ca
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/infiniband/core/cm.c
patch
|
blob
|
history
diff --git
a/drivers/infiniband/core/cm.c
b/drivers/infiniband/core/cm.c
index
71c7c4c
..
304429f
100644
(file)
--- a/
drivers/infiniband/core/cm.c
+++ b/
drivers/infiniband/core/cm.c
@@
-1073,6
+1073,7
@@
struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device,
/* Sharing an ib_cm_id with different handlers is not
* supported */
spin_unlock_irqrestore(&cm.lock, flags);
+ ib_destroy_cm_id(cm_id);
return ERR_PTR(-EINVAL);
}
atomic_inc(&cm_id_priv->refcount);