r8169: move setting ERI register 0x1d0 for RTL8106
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 9 Jan 2020 19:29:21 +0000 (20:29 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 11 Jan 2020 00:41:34 +0000 (16:41 -0800)
Writing this ERI register is a MAC setting, so move it to
rtl_hw_start_8106().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index dccc5a1..d157c97 100644 (file)
@@ -3425,8 +3425,6 @@ static void rtl8106e_hw_phy_config(struct rtl8169_private *tp,
 
        rtl_eri_write(tp, 0x1b0, ERIAR_MASK_0011, 0x0000);
        rtl_writephy_batch(phydev, phy_reg_init);
-
-       rtl_eri_write(tp, 0x1d0, ERIAR_MASK_0011, 0x0000);
 }
 
 static void rtl8125_1_hw_phy_config(struct rtl8169_private *tp,
@@ -4999,6 +4997,8 @@ static void rtl_hw_start_8106(struct rtl8169_private *tp)
        RTL_W8(tp, MCU, RTL_R8(tp, MCU) | EN_NDP | EN_OOB_RESET);
        RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) & ~PFM_EN);
 
+       rtl_eri_write(tp, 0x1d0, ERIAR_MASK_0011, 0x0000);
+
        rtl_pcie_state_l2l3_disable(tp);
        rtl_hw_aspm_clkreq_enable(tp, true);
 }