regulator: s5m8767: initialize driver via module_platform_driver
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 21 Sep 2020 20:36:16 +0000 (22:36 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 21 Sep 2020 23:45:16 +0000 (00:45 +0100)
The driver was using subsys_initcall() because in old times deferred
probe was not supported everywhere and specific ordering was needed.
Since probe deferral works fine and specific ordering is discouraged
(hides dependencies between drivers and couples their boot order), the
driver can be converted to regular module_platform_driver.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200921203616.19623-1-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/s5m8767.c

index 4abd3ed..3fa4721 100644 (file)
@@ -1000,18 +1000,7 @@ static struct platform_driver s5m8767_pmic_driver = {
        .probe = s5m8767_pmic_probe,
        .id_table = s5m8767_pmic_id,
 };
-
-static int __init s5m8767_pmic_init(void)
-{
-       return platform_driver_register(&s5m8767_pmic_driver);
-}
-subsys_initcall(s5m8767_pmic_init);
-
-static void __exit s5m8767_pmic_exit(void)
-{
-       platform_driver_unregister(&s5m8767_pmic_driver);
-}
-module_exit(s5m8767_pmic_exit);
+module_platform_driver(s5m8767_pmic_driver);
 
 /* Module information */
 MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>");