pinctrl: renesas: checker: Validate I/O voltage configs consistency

Validate consistency of the pin control tables for pins with I/O voltage
capabilities.  If a pin has I/O voltage register bits declarations
through .pin_to_pocctrl(), the SH_PFC_PIN_CFG_IO_VOLTAGE flag should be
set in the pin's configs, and vice versa.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/de81cced01ae3f26d341177d66d4b8e918fbfb76.1640270559.git.geert+renesas@glider.be

diff --git a/drivers/pinctrl/renesas/core.c b/drivers/pinctrl/renesas/core.c
index 1789c96ad2aa2c7996df58d356b6df611ca62e99..ef88359ddf5c0f2a96f7ca4a799e87c129ea28c3 100644 (file)
--- a/drivers/pinctrl/renesas/core.c
+++ b/drivers/pinctrl/renesas/core.c
@@ -747,6 +747,7 @@ static unsigned int sh_pfc_errors __initdata;
 static unsigned int sh_pfc_warnings __initdata;
 static bool sh_pfc_bias_done __initdata;
 static bool sh_pfc_drive_done __initdata;
+static bool sh_pfc_power_done __initdata;
 static struct {
        u32 reg;
        u32 bits;
@@ -1009,6 +1010,7 @@ static void __init sh_pfc_check_info(const struct sh_pfc_soc_info *info)
        sh_pfc_num_enums = 0;
        sh_pfc_bias_done = false;
        sh_pfc_drive_done = false;
+       sh_pfc_power_done = false;
 
        /* Check pins */
        for (i = 0; i < info->nr_pins; i++) {
@@ -1082,6 +1084,18 @@ static void __init sh_pfc_check_info(const struct sh_pfc_soc_info *info)
                                                   pin->name);
                        }
                }
+
+               if (pin->configs & SH_PFC_PIN_CFG_IO_VOLTAGE) {
+                       if (!info->ops || !info->ops->pin_to_pocctrl)
+                               sh_pfc_err_once(power, "SH_PFC_PIN_CFG_IO_VOLTAGE flag set but .pin_to_pocctrl() not implemented\n");
+                       else if (info->ops->pin_to_pocctrl(pin->pin, &x) < 0)
+                               sh_pfc_err("pin %s: SH_PFC_PIN_CFG_IO_VOLTAGE set but invalid pin_to_pocctrl()\n",
+                                          pin->name);
+               } else if (info->ops && info->ops->pin_to_pocctrl &&
+                          info->ops->pin_to_pocctrl(pin->pin, &x) >= 0) {
+                       sh_pfc_warn("pin %s: SH_PFC_PIN_CFG_IO_VOLTAGE not set but valid pin_to_pocctrl()\n",
+                                   pin->name);
+               }
        }
 
        /* Check groups and functions */