iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc
authorWan Jiabing <wanjiabing@vivo.com>
Thu, 21 Oct 2021 12:18:23 +0000 (08:18 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 17 Nov 2021 17:51:32 +0000 (17:51 +0000)
Fix following coccicheck warning:
./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Replace return by goto here.

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211021121826.6339-1-wanjiabing@vivo.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/stm32-adc.c

index 6245434..7f1fb36 100644 (file)
@@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
                        if (strlen(name) >= STM32_ADC_CH_SZ) {
                                dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n",
                                        name, STM32_ADC_CH_SZ);
-                               return -EINVAL;
+                               ret = -EINVAL;
+                               goto err;
                        }
                        strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ);
                        ret = stm32_adc_populate_int_ch(indio_dev, name, val);