staging: wfx: drop useless loop
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Fri, 29 May 2020 12:16:03 +0000 (14:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Jun 2020 19:22:51 +0000 (21:22 +0200)
It is guarantee that the loop will stop at first iteration. So drop the
loop.

Fixes: 6bf418c50f98a ("staging: wfx: change the way to choose frame to send")
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200529121603.1050891-2-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/queue.c

index 75df4ac..93ea2b7 100644 (file)
@@ -291,15 +291,12 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
 
        if (atomic_read(&wdev->tx_lock))
                return NULL;
-
-       for (;;) {
-               skb = wfx_tx_queues_get_skb(wdev);
-               if (!skb)
-                       return NULL;
-               skb_queue_tail(&wdev->tx_pending, skb);
-               wake_up(&wdev->tx_dequeue);
-               tx_priv = wfx_skb_tx_priv(skb);
-               tx_priv->xmit_timestamp = ktime_get();
-               return (struct hif_msg *)skb->data;
-       }
+       skb = wfx_tx_queues_get_skb(wdev);
+       if (!skb)
+               return NULL;
+       skb_queue_tail(&wdev->tx_pending, skb);
+       wake_up(&wdev->tx_dequeue);
+       tx_priv = wfx_skb_tx_priv(skb);
+       tx_priv->xmit_timestamp = ktime_get();
+       return (struct hif_msg *)skb->data;
 }