iomap: add a filesystem hook for direct I/O bio submission
authorGoldwyn Rodrigues <rgoldwyn@suse.com>
Tue, 14 May 2019 23:54:27 +0000 (18:54 -0500)
committerDavid Sterba <dsterba@suse.com>
Mon, 25 May 2020 11:12:53 +0000 (13:12 +0200)
This helps filesystems to perform tasks on the bio while submitting for
I/O. This could be post-write operations such as data CRC or data
replication for fs-handled RAID.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/iomap/direct-io.c
include/linux/iomap.h

index 20dde5a..f88ba6e 100644 (file)
@@ -59,7 +59,7 @@ int iomap_dio_iopoll(struct kiocb *kiocb, bool spin)
 EXPORT_SYMBOL_GPL(iomap_dio_iopoll);
 
 static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
-               struct bio *bio)
+               struct bio *bio, loff_t pos)
 {
        atomic_inc(&dio->ref);
 
@@ -67,7 +67,12 @@ static void iomap_dio_submit_bio(struct iomap_dio *dio, struct iomap *iomap,
                bio_set_polled(bio, dio->iocb);
 
        dio->submit.last_queue = bdev_get_queue(iomap->bdev);
-       dio->submit.cookie = submit_bio(bio);
+       if (dio->dops && dio->dops->submit_io)
+               dio->submit.cookie = dio->dops->submit_io(
+                               file_inode(dio->iocb->ki_filp),
+                               iomap, bio, pos);
+       else
+               dio->submit.cookie = submit_bio(bio);
 }
 
 static ssize_t iomap_dio_complete(struct iomap_dio *dio)
@@ -191,7 +196,7 @@ iomap_dio_zero(struct iomap_dio *dio, struct iomap *iomap, loff_t pos,
        get_page(page);
        __bio_add_page(bio, page, len, 0);
        bio_set_op_attrs(bio, REQ_OP_WRITE, flags);
-       iomap_dio_submit_bio(dio, iomap, bio);
+       iomap_dio_submit_bio(dio, iomap, bio, pos);
 }
 
 static loff_t
@@ -299,11 +304,11 @@ iomap_dio_bio_actor(struct inode *inode, loff_t pos, loff_t length,
                }
 
                dio->size += n;
-               pos += n;
                copied += n;
 
                nr_pages = iov_iter_npages(dio->submit.iter, BIO_MAX_PAGES);
-               iomap_dio_submit_bio(dio, iomap, bio);
+               iomap_dio_submit_bio(dio, iomap, bio, pos);
+               pos += n;
        } while (nr_pages);
 
        /*
index 8b09463..5b48753 100644 (file)
@@ -252,6 +252,8 @@ int iomap_writepages(struct address_space *mapping,
 struct iomap_dio_ops {
        int (*end_io)(struct kiocb *iocb, ssize_t size, int error,
                      unsigned flags);
+       blk_qc_t (*submit_io)(struct inode *inode, struct iomap *iomap,
+                       struct bio *bio, loff_t file_offset);
 };
 
 ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,